[webkit-reviews] review granted: [Bug 129738] [GTK] MiniBrowser crashes when opening several urls passed as command line options : [Attachment 225875] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 129738: [GTK] MiniBrowser crashes when opening several urls passed as
command line options
https://bugs.webkit.org/show_bug.cgi?id=129738

Attachment 225875: Patch
https://bugs.webkit.org/attachment.cgi?id=225875&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225875&action=review


r=me with comments

> Tools/MiniBrowser/gtk/main.c:286
> +	   g_object_unref(webkitSettings);

I'd prefer using g_clear_object(&webkitSettings);

We could do the same above when we do:

    if (!addSettingsGroupToContext(context, webkitSettings)) {
	g_object_unref(webkitSettings);
	webkitSettings = 0;
    }