[webkit-reviews] review granted: [Bug 129727] appendChild shouldn't invalidate LiveNodeLists and HTMLCollections if they don't have valid caches : [Attachment 225868] Reverted the erronous change
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 5 01:30:28 PST 2014
Andreas Kling <akling at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 129727: appendChild shouldn't invalidate LiveNodeLists and HTMLCollections
if they don't have valid caches
https://bugs.webkit.org/show_bug.cgi?id=129727
Attachment 225868: Reverted the erronous change
https://bugs.webkit.org/attachment.cgi?id=225868&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225868&action=review
Good idea. r=me
> Source/WebCore/dom/Node.cpp:728
> + HashSet<LiveNodeList*> liveNodeLists;
> + liveNodeLists.swap(m_listsInvalidatedAtDocument);
I'd write this with move semantics:
HashSet<LiveNodeList*> liveNodeLists = std::move(m_listsInvalidatedAtDocument);
> Source/WebCore/dom/Node.cpp:733
> + HashSet<HTMLCollection*> collectionLists;
> + collectionLists.swap(m_collectionsInvalidatedAtDocument);
Same here.
More information about the webkit-reviews
mailing list