[webkit-reviews] review granted: [Bug 129655] Inspector does not restore breakpoints after a page reload : [Attachment 225829] the patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 129655: Inspector does not restore breakpoints after a page reload
https://bugs.webkit.org/show_bug.cgi?id=129655

Attachment 225829: the patch
https://bugs.webkit.org/attachment.cgi?id=225829&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225829&action=review


> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:713
> +    ErrorString dummyError;
>      setOverlayMessage(&dummyError, nullptr);

setOverlayMessage currently does nothing. And I wouldn't associate this with
"clearDebuggerBreakpointState". Maybe we should just remove it. Otherwise,
leave it here and we will clean it up later.

>> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:723
>> +	clearDebuggerBreakpointState();
> 
> Shouldn't you clear the breakpoints before continuing the program?

I agree with Mark's comment. In fact, clearDebuggerBreakpointState already does
a continue program, so you can remove the line from here. r=me with that
change.