[webkit-reviews] review denied: [Bug 122061] Gap rendered between nested elements : [Attachment 225029] Patch

Tue Mar 4 13:59:54 PST 2014

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Deepak Mittal
<deepak.m1 at samsung.com>'s request for review:
Bug 122061: Gap rendered between nested elements
https://bugs.webkit.org/show_bug.cgi?id=122061

Attachment 225029: Patch
https://bugs.webkit.org/attachment.cgi?id=225029&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225029&action=review

>> Source/WebCore/rendering/RenderBox.cpp:1157
>> +	    return BackgroundBleedBackgroundOverBorder;
> 
> I am not sure if it's the right approach to fix background bleeding over
nested items. Not only the return value is contradicting the condition
(!hasBackground() -> BackgroundBleedBackgroundOverBorder), but I can make a
small change to your test case and the bleeding comes back. -the small change
is moving the background color from the body to the outer div box. Now that the
background color is on the <div> as opposed to the <body>, this condition
evaluates to false and the bleeding happens.

Zalan is right.

> LayoutTests/fast/dom/HTMLDivElement/div-border-radius-expected.html:8
> +			body{background:#F00;}
> +			.box{ background:#FFF; border-radius: 30px; border: 1px
solid #FFF; margin:50px; overflow: hidden; padding: 0px;}
> +			.box2{ background: #FFF; padding: 100px; margin: 0px;}
> +			.correctBox{border-radius: 30px; border: 1px solid
#FFF; margin:50px; background: #FFF; padding: 100px;}

Please format your CSS nicely.