[webkit-reviews] review granted: [Bug 129690] [iOS WebKit2]: Next/Prev button in the accessory bar do not work : [Attachment 225796] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 129690: [iOS WebKit2]: Next/Prev button in the accessory bar do not work
https://bugs.webkit.org/show_bug.cgi?id=129690

Attachment 225796: Patch
https://bugs.webkit.org/attachment.cgi?id=225796&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225796&action=review


> Source/WebKit2/UIProcess/WebPageProxy.h:483
> +    void nextAssistedNode(bool isForward);

It's not clear if this is a getter or a command. I think it should be
focusNextAssistedNode, or moveToNextAssistedNode. It would also be nice if the
param were an enum.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1594
> +static inline bool hasFocusableNode(Node* startNode, Page* page, bool
isForward)
> +{
> +    return nextFocusableNode(startNode, page, isForward) != nil;
> +}
> +
> +void WebPage::nextAssistedNode(bool isForward)
> +{
> +    Node* nextNode = nextFocusableNode(m_assistedNode.get(), m_page.get(),
isForward);
> +    if (nextNode)
> +	   toElement(nextNode)->focus();
> +}

I think all these Node* should really be Element* (but should be fixed in a
subsequent patch)