[webkit-reviews] review denied: [Bug 127982] [CSS Shapes][css clip-path] rounded corner calculation for box shapes is wrong : [Attachment 225793] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 4 11:38:21 PST 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 127982: [CSS Shapes][css clip-path] rounded corner calculation for box
shapes is wrong
https://bugs.webkit.org/show_bug.cgi?id=127982
Attachment 225793: Patch
https://bugs.webkit.org/attachment.cgi?id=225793&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225793&action=review
>> Source/WebCore/rendering/LayoutBox.cpp:40
>> + LayoutUnit ratio = radius / margin;
>
> No check for zero before?
if margin is 0 this is a divide by zero.
More information about the webkit-reviews
mailing list