[webkit-reviews] review granted: [Bug 129650] Merge API shims and JSLock : [Attachment 225790] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 4 11:13:30 PST 2014


Mark Lam <mark.lam at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 129650: Merge API shims and JSLock
https://bugs.webkit.org/show_bug.cgi?id=129650

Attachment 225790: Patch
https://bugs.webkit.org/attachment.cgi?id=225790&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225790&action=review


Nice.  r=me with minor fix.

> Source/JavaScriptCore/runtime/JSLock.cpp:142
> +    m_entryIdentifierTable =
wtfThreadData().setCurrentIdentifierTable(m_vm->identifierTable);

"wtfThreadData()" ==> "threadData".


More information about the webkit-reviews mailing list