[webkit-reviews] review granted: [Bug 129637] [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble : [Attachment 225719] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 4 09:52:56 PST 2014


Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 129637: [GTK] Give the WebKit GObject DOM bindings API break detection it's
own buildbot bubble
https://bugs.webkit.org/show_bug.cgi?id=129637

Attachment 225719: Patch
https://bugs.webkit.org/attachment.cgi?id=225719&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225719&action=review


Thanks!

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:663
> +    def evaluateCommand(self, cmd):
> +	   if self.missingAPI:
> +	       return FAILURE
> +	   return SUCCESS

I think we can return WARNINGS in case of compatible api changes, so that I
won't miss them :-)


More information about the webkit-reviews mailing list