[webkit-reviews] review granted: [Bug 129673] Micro-optimize Strings in JS bindings. : [Attachment 225762] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 129673: Micro-optimize Strings in JS bindings.
https://bugs.webkit.org/show_bug.cgi?id=129673

Attachment 225762: Patch
https://bugs.webkit.org/attachment.cgi?id=225762&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review


> Source/WebCore/bindings/js/JSDOMBinding.h:597
> +    return JSC::jsStringWithWeakOwner(vm, *s.impl());

Why don't we use *stringImpl instead?