[webkit-reviews] review granted: [Bug 129632] [iOS WebKit2]: Text fields don't zoom in when focused : [Attachment 225704] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 3 16:26:48 PST 2014
Benjamin Poulain <benjamin at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 129632: [iOS WebKit2]: Text fields don't zoom in when focused
https://bugs.webkit.org/show_bug.cgi?id=129632
Attachment 225704: Patch
https://bugs.webkit.org/attachment.cgi?id=225704&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225704&action=review
> Source/WebKit2/Shared/AssistedNodeInformation.h:97
> + : minimumScaleFactor(0.1)
> + , maximumScaleFactor(DBL_MAX)
Maybe -inf and inf instead?
> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:416
> + minimumScrollDistance:0];
The indent is wrong here.
More information about the webkit-reviews
mailing list