[webkit-reviews] review granted: [Bug 129557] Subpixel rendering: Make GraphicsLayer::fillRect FloatRoundedRect based and cleanup dependencies. : [Attachment 225682] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 129557: Subpixel rendering: Make GraphicsLayer::fillRect FloatRoundedRect
based and cleanup dependencies.
https://bugs.webkit.org/show_bug.cgi?id=129557

Attachment 225682: Patch
https://bugs.webkit.org/attachment.cgi?id=225682&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225682&action=review


> Source/WebCore/platform/graphics/FloatRoundedRect.cpp:151
> +    && m_radii.bottomLeft().width() + m_radii.bottomRight().width() <=
m_rect.width()
> +    && m_radii.topLeft().height() + m_radii.bottomLeft().height() <=
m_rect.height()
> +    && m_radii.topRight().height() + m_radii.bottomRight().height() <=
m_rect.height();

Indent these lines.

> Source/WebCore/platform/graphics/Path.cpp:135
> +    if (rect.width() < radii.topLeft().width() + radii.topRight().width()
> +	   || rect.width() < radii.bottomLeft().width() +
radii.bottomRight().width()
> +	   || rect.height() < radii.topLeft().height() +
radii.bottomLeft().height()
> +	   || rect.height() < radii.topRight().height() +
radii.bottomRight().height()) {
>	   // If all the radii cannot be accommodated, return a rect.

Is this the same logic as isRenderable?