[webkit-reviews] review granted: [Bug 129185] Web Inspector: Remove WebInspector.EventHandler in favor of WebInspector.EventListenerSet : [Attachment 225701] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 3 15:42:51 PST 2014
Timothy Hatcher <timothy at apple.com> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 129185: Web Inspector: Remove WebInspector.EventHandler in favor of
WebInspector.EventListenerSet
https://bugs.webkit.org/show_bug.cgi?id=129185
Attachment 225701: Patch
https://bugs.webkit.org/attachment.cgi?id=225701&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225701&action=review
> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1258
> + this._popoverEventHandler = new
WebInspector.EventListenerSet(this, "Popover listeners");
This should be called _popoverEventListeners or _popoverEventListenerSet to
match the class name better.
More information about the webkit-reviews
mailing list