[webkit-reviews] review granted: [Bug 128173] [CSS Grid Layout] Percentages of indefinite sizes should compute to auto : [Attachment 223446] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 128173: [CSS Grid Layout] Percentages of indefinite sizes should compute to
auto
https://bugs.webkit.org/show_bug.cgi?id=128173

Attachment 223446: Patch
https://bugs.webkit.org/attachment.cgi?id=223446&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223446&action=review


> Source/WebCore/rendering/RenderGrid.cpp:413
> +	       DEFINE_STATIC_LOCAL(GridTrackSize, autoTrackSize, (Auto));

New code should not use DEFINE_STATIC_LOCAL (I think we should rename it
DEPRECATED_DEFINE_STATIC_LOCAL). Instead you should just use static
NeverDestroyed. There are lots of examples of that all over the code.