[webkit-reviews] review denied: [Bug 129387] Respect SVG fragment identifiers in <img> src attribute : [Attachment 225640] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 129387: Respect SVG fragment identifiers in <img> src attribute
https://bugs.webkit.org/show_bug.cgi?id=129387

Attachment 225640: Patch
https://bugs.webkit.org/attachment.cgi?id=225640&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225640&action=review


Small comments but otherwise looks good.

> Source/WebCore/svg/graphics/SVGImage.cpp:255
> +    if (!m_url.isEmpty())

Could you add an ASSERT(view) right behind FrameView* view = frameView();
earlier in this method please?

> Source/WebCore/svg/graphics/SVGImageForContainer.cpp:57
>  void SVGImageForContainer::setURL(const URL& url)

If it is possible to remove #include "SVGImage.h" from SVGImageForContainer.h,
then do this in this patch as well please.

If not, remove the header include from the SVGImageForContainer.cpp and call
m_image->setURL(url) from the header:

void setURL(const URL& url) { m_image->setURL(url); }