[webkit-reviews] review granted: [Bug 129584] CodeBlock::hasDebuggerRequests() should returning a bool instead of an int : [Attachment 225613] the patch.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 129584: CodeBlock::hasDebuggerRequests() should returning a bool instead of
an int
https://bugs.webkit.org/show_bug.cgi?id=129584

Attachment 225613: the patch.
https://bugs.webkit.org/attachment.cgi?id=225613&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225613&action=review


> Source/JavaScriptCore/bytecode/CodeBlock.h:880
> +    bool hasDebuggerRequests() const { return !!m_debuggerRequests; }

By the way, there is no need for the !! here. That was only needed in compilers
that lacked bool support, but we don’t compile WebKit with those kinds of old
compilers.