[webkit-reviews] review granted: [Bug 129562] No need to ASSERT on infinite values in CSS lengths : [Attachment 225573] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 129562: No need to ASSERT on infinite values in CSS lengths
https://bugs.webkit.org/show_bug.cgi?id=129562

Attachment 225573: Patch
https://bugs.webkit.org/attachment.cgi?id=225573&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225573&action=review


> Source/WebCore/css/CSSPrimitiveValue.cpp:-259
> -    ASSERT(std::isfinite(num));

std::isfinite also checks for NAN. Instead of deleting the assertion I think
you should change it to:

    ASSERT(!std::isnan(num));