[webkit-reviews] review granted: [Bug 129548] [Mac] Crash in MediaPlayer::rateChanged() : [Attachment 225555] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 129548: [Mac] Crash in MediaPlayer::rateChanged()
https://bugs.webkit.org/show_bug.cgi?id=129548

Attachment 225555: Patch
https://bugs.webkit.org/attachment.cgi?id=225555&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225555&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:2142
> +	   if (!weakThis)
> +	       return;
> +	   function();

This needs a comment. The technique of checking weakThis because we know that’s
a precondition for function still being OK to call is subtle. Not the good kind
of subtle for programming.