[webkit-reviews] review granted: [Bug 129539] Fix srcset related bugs : [Attachment 225548] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 1 14:26:56 PST 2014
Andreas Kling <akling at apple.com> has granted Yoav Weiss <yoav at yoav.ws>'s
request for review:
Bug 129539: Fix srcset related bugs
https://bugs.webkit.org/show_bug.cgi?id=129539
Attachment 225548: Patch
https://bugs.webkit.org/attachment.cgi?id=225548&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225548&action=review
r=me!
> Source/WebCore/html/parser/HTMLParserIdioms.cpp:-401
> - for (size_t i = 0; i < imageCandidates.size() - 1; ++i) {
> + for (size_t i = 0; i < imageCandidates.size() - 1; ++i)
> if (imageCandidates[i].scaleFactor() >= deviceScaleFactor)
> return imageCandidates[i];
> - }
WebKit style is to keep the { } braces here since there is more than one line
inside the for loop.
More information about the webkit-reviews
mailing list