[webkit-reviews] review canceled: [Bug 134417] Use Vector::swap() instead of std::move() in SVGDocumentExtensions::rebuildElements() : [Attachment 234024] Patch and layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 30 17:14:28 PDT 2014


Daniel Bates <dbates at webkit.org> has canceled Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 134417: Use Vector::swap() instead of std::move() in
SVGDocumentExtensions::rebuildElements()
https://bugs.webkit.org/show_bug.cgi?id=134417

Attachment 234024: Patch and layout test
https://bugs.webkit.org/attachment.cgi?id=234024&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Clearing review flag. After talking with Darin Adler and Anders Carlsson today
(06/30), a better approach is to come up with a WTF::move() function that
asserts we aren't called with a const value.


More information about the webkit-reviews mailing list