[webkit-reviews] review denied: [Bug 134473] [iOS] languageSpecificFallbackFont() is not consistent : [Attachment 234121] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 30 17:06:01 PDT 2014

Darin Adler <darin at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 134473: [iOS] languageSpecificFallbackFont() is not consistent

Attachment 234121: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234121&action=review

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:155
> +    if (c < 0x1401)
> +	   return LanguageSpecificFont::None;

Looks to me like this changes behavior. The old code would return
LanguageSpecificFont::Khmer for 0x1200-0x1400.

More information about the webkit-reviews mailing list