[webkit-reviews] review granted: [Bug 134467] WebBackForwardListItems should hold on to PageState objects : [Attachment 234111] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 134467: WebBackForwardListItems should hold on to PageState objects
https://bugs.webkit.org/show_bug.cgi?id=134467

Attachment 234111: Patch
https://bugs.webkit.org/attachment.cgi?id=234111&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234111&action=review


OK

> Source/WebKit2/Shared/WebBackForwardListItem.cpp:41
> +    m_pageState.mainFrameState.originalURLString = originalURL;
> +    m_pageState.mainFrameState.urlString = url;
> +    m_pageState.title = title;

No constructor for PageState? Is it just a struct?

> Source/WebKit2/Shared/WebBackForwardListItem.cpp:69
> +    encoder << m_pageState.mainFrameState.originalURLString;
> +    encoder << m_pageState.mainFrameState.urlString;
> +    encoder << m_pageState.title;

No helper function for pageState? Doesn’t have to be a member function.