[webkit-reviews] review granted: [Bug 134133] [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree : [Attachment 234088] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 30 13:27:05 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 134133: [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=134133

Attachment 234088: Patch
https://bugs.webkit.org/attachment.cgi?id=234088&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234088&action=review


> Tools/DumpRenderTree/mac/DumpRenderTree.mm:535
>	   fprintf(stderr, "Failed to add CGFont to GraphicsServices for the %s
font.\n", sectionName.c_str());

Shouldn't this print error details?


More information about the webkit-reviews mailing list