[webkit-reviews] review granted: [Bug 134424] [iOS][WK2] Move tap highlight to the inverseScaleRootView : [Attachment 234041] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 28 03:16:44 PDT 2014

Tim Horton <thorton at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 134424: [iOS][WK2] Move tap highlight to the inverseScaleRootView

Attachment 234041: Patch

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234041&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:74
> +const CGFloat UIWebViewMinimumHighlightRadius = 2.0;

This constant name seems nonideal.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:521
> +    CGFloat selfScale = [[self layer] transform].m11;

moar dot notation

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:559
> +    [borderRadii addObject:[NSValue
valueWithCGSize:CGSizeMake(_tapHighlightInformation.topLeftRadius.width() +
_tapHighlightInformation.topLeftRadius.height() +

I bet you could come up with a much less wordy way to write these.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:806
> +			    [[_highlightView layer] setOpacity:0];

dots etc.

More information about the webkit-reviews mailing list