[webkit-reviews] review granted: [Bug 134426] [iOS WK2] position:fixed inside accelerated overflow:scroll is jumpy : [Attachment 234042] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 134426: [iOS WK2] position:fixed inside accelerated overflow:scroll is
jumpy
https://bugs.webkit.org/show_bug.cgi?id=134426

Attachment 234042: Patch
https://bugs.webkit.org/attachment.cgi?id=234042&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234042&action=review


> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:-49
> -    // FIXME: We should implement this when we support
ScrollingTreeScrollingNodes as children.

ha!

>
Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm
:36
> +#import <wtf/TemporaryChange.h>

this has to be sorted wrong because of case sensitivity

>
Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm
:244
> +    WTFLogAlways("scrollViewDidScroll to %.2f\n", scrollPosition.y());

I don't think so!