[webkit-reviews] review granted: [Bug 134416] reduce dynamic memory allocation in css jit compiler : [Attachment 234023] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 134416: reduce dynamic memory allocation in css jit compiler
https://bugs.webkit.org/show_bug.cgi?id=134416

Attachment 234023: Patch
https://bugs.webkit.org/attachment.cgi?id=234023&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234023&action=review


> Source/WTF/ChangeLog:35
> +	   (WTF::inlineCapacity>::checkValidity):
> +	   (WTF::inlineCapacity>::checkIndexValidity):
> +	   (WTF::inlineCapacity>::invalidateIterators):
> +	   (WTF::inlineCapacity>::Deque):
> +	   (WTF::=):
> +	   (WTF::inlineCapacity>::destroyAll):
> +	   (WTF::inlineCapacity>::~Deque):
> +	   (WTF::inlineCapacity>::swap):
> +	   (WTF::inlineCapacity>::clear):
> +	   (WTF::inlineCapacity>::expandCapacityIfNeeded):
> +	   (WTF::inlineCapacity>::expandCapacity):
> +	   (WTF::inlineCapacity>::append):
> +	   (WTF::inlineCapacity>::prepend):
> +	   (WTF::inlineCapacity>::removeFirst):
> +	   (WTF::inlineCapacity>::removeLast):
> +	   (WTF::inlineCapacity>::remove):
> +	   (WTF::inlineCapacity>::addToIteratorsList):
> +	   (WTF::inlineCapacity>::removeFromIteratorsList):
> +	   (WTF::inlineCapacity>::DequeIteratorBase):
> +	   (WTF::inlineCapacity>::~DequeIteratorBase):
> +	   (WTF::inlineCapacity>::isEqual):
> +	   (WTF::inlineCapacity>::increment):
> +	   (WTF::inlineCapacity>::decrement):
> +	   (WTF::inlineCapacity>::after):
> +	   (WTF::inlineCapacity>::before):

The script generated garbage here. Please either fix these manually or remove
them. I think it’s OK to omit the list of function names entirely.

> Source/WebCore/cssjit/RegisterAllocator.h:65
> +    JSC::ARMRegisters::r9,

Change not mentioned in the change log.

> Source/WebCore/cssjit/RegisterAllocator.h:73
> +    JSC::ARMRegisters::r8,
> +    JSC::ARMRegisters::r10,
> +    JSC::ARMRegisters::r11,

Change not mentioned in the change log.