[webkit-reviews] review granted: [Bug 134407] Lazily link frameworks in WebVideoFullscreenInterfaceAVKit. : [Attachment 234008] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 27 12:50:14 PDT 2014

Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 134407: Lazily link frameworks in WebVideoFullscreenInterfaceAVKit.

Attachment 234008: Patch

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234008&action=review

> Source/WebCore/ChangeLog:10
> +	   Link AVPlayerController on use.

Nit: *Load" instead of *Link*?

> Source/WebCore/ChangeLog:15
> +	   Remove linking on construction.
> +	   (WebVideoFullscreenInterfaceAVKit::setCurrentTime): Link
AVValueTiming on use.
> +	   (WebVideoFullscreenInterfaceAVKit::setupFullscreen): Link several
classes on use.
> +	   (WebVideoFullscreenInterfaceAVKit::exitFullscreen): Link UIColor on


More information about the webkit-reviews mailing list