[webkit-reviews] review granted: [Bug 128072] [ftlopt] GC should keep structures alive if they are inlined into optimized code (DFG or FTL) and their globalObject is alive : [Attachment 233951] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 128072: [ftlopt] GC should keep structures alive if they are inlined into
optimized code (DFG or FTL) and their globalObject is alive
https://bugs.webkit.org/show_bug.cgi?id=128072

Attachment 233951: the patch
https://bugs.webkit.org/attachment.cgi?id=233951&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233951&action=review


r=me, with some fixate

> Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:85
> +	   if (false && jit.codeBlock()->instructionCount() == 681)
> +	       jit.breakpoint();

Please remove.

> Source/JavaScriptCore/runtime/Executable.h:457
> +    bool m_didTryToEnterInLoop;

It looks like this data member is not initialized in the constructor.