[webkit-reviews] review granted: [Bug 134371] JSContext Inspection: Provide a way to use a non-Main RunLoop for Inspector JavaScript Evaluations : [Attachment 233949] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 134371: JSContext Inspection: Provide a way to use a non-Main RunLoop for
Inspector JavaScript Evaluations
https://bugs.webkit.org/show_bug.cgi?id=134371

Attachment 233949: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=233949&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233949&action=review


Looks good.

> Source/JavaScriptCore/API/JSContextPrivate.h:51
> + at property (setter=_setDebuggerRunLoop:) CFRunLoopRef _debuggerRunLoop
NS_AVAILABLE(10_10, 8_0);

It is annoying this needs to use a C type in ObjC. But at least NSRunLoop has a
getter for CFRunLoopRef.

I would say make this use NSRunLoop and have the implementation for
_setDebuggerRunLoop: translate to a CFRunLoopRef. But there is no way to turn a
CFRunLoopRef into a NSRunLoop.