[webkit-reviews] review granted: [Bug 133605] [GTK] 8tracks.com triggers annoying pop-up window/installation of "About protocol source plugin" (GStreamer?) : [Attachment 233975] patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 133605: [GTK] 8tracks.com triggers annoying pop-up window/installation of
"About protocol source plugin" (GStreamer?)
https://bugs.webkit.org/show_bug.cgi?id=133605

Attachment 233975: patch
https://bugs.webkit.org/attachment.cgi?id=233975&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233975&action=review


>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:279
>      String cleanUrl(url);
>  
> +    if (kurl.isBlankURL())
> +	   return;

That cleanUrl (that should be cleanURL) would be unused in case kurl is blank.
Also, even if it was already there, I'm not sure kurl is a good name . . .