[webkit-reviews] review requested: [Bug 134371] JSContext Inspection: Provide a way to use a non-Main RunLoop for Inspector JavaScript Evaluations : [Attachment 233949] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 26 17:33:43 PDT 2014
Joseph Pecoraro <joepeck at webkit.org> has asked for review:
Bug 134371: JSContext Inspection: Provide a way to use a non-Main RunLoop for
Inspector JavaScript Evaluations
https://bugs.webkit.org/show_bug.cgi?id=134371
Attachment 233949: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=233949&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
I tested this on OS X and iOS with a simple test application to check edge
conditions. Everything behaved as I expected. I want to do some more testing on
this, and maybe include an updated patch with some basic JSC tests for the
property.
Unfortunately there is some duplicated code in this patch between the global
shared path and this debuggable specific path. I was not sure how best to share
the code that didn't just look uglier.
More information about the webkit-reviews
mailing list