[webkit-reviews] review canceled: [Bug 134269] [iOS][WK2] Implement WKPDFView smart magnification : [Attachment 233746] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 26 16:37:15 PDT 2014
Tim Horton <thorton at apple.com> has canceled Tim Horton <thorton at apple.com>'s
request for review:
Bug 134269: [iOS][WK2] Implement WKPDFView smart magnification
https://bugs.webkit.org/show_bug.cgi?id=134269
Attachment 233746: patch
https://bugs.webkit.org/attachment.cgi?id=233746&action=review
------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233746&action=review
r=dan with lots of comments below
> Source/WebKit2/UIProcess/ios/WKPDFView.h:30
> #import <UIKit/UIView.h>
> +#import <CorePDF/UIPDFPageView.h>
sorting!
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:49
> +static const float smartMagnificationElementPadding = 0.05;
CGFloat
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:72
> + bool _isStartingZoom;
Big BOOL
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:185
> + [pageInfo.view setDelegate:self];
clear delegates
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:270
> + _isStartingZoom = true;
YES etc
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:272
> + bool isImage = kind == kUIPDFObjectKindGraphic;
Big BOOL
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:275
> + double dx = smartMagnificationElementPadding *
targetRect.size.width;
CGFloat
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:277
> + targetRect.origin.x -= dx;
> + targetRect.size.width += 2 * dx;
There should be a CGRect thing for this
More information about the webkit-reviews
mailing list