[webkit-reviews] review granted: [Bug 133395] Web Inspector: debugger should be able to show variable types : [Attachment 233830] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 26 12:00:42 PDT 2014


Filip Pizlo <fpizlo at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 133395: Web Inspector: debugger should be able to show variable types
https://bugs.webkit.org/show_bug.cgi?id=133395

Attachment 233830: patch
https://bugs.webkit.org/attachment.cgi?id=233830&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233830&action=review


I will land this.

> Source/JavaScriptCore/runtime/HighFidelityLog.cpp:91
> +    LogEntry* temp = m_logStartPtr;
> +    m_logStartPtr = m_nextBuffer;
> +    m_nextBuffer = temp;
> +    

std::swap()


More information about the webkit-reviews mailing list