[webkit-reviews] review granted: [Bug 134350] [iOS] no need to deactivate audio session : [Attachment 233916] Proposed patch.

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 134350: [iOS] no need to deactivate audio session
https://bugs.webkit.org/show_bug.cgi?id=134350

Attachment 233916: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=233916&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233916&action=review


r=me

> Source/WebCore/ChangeLog:9
> +	   [iOS] no need to deactivate audio session
> +	   https://bugs.webkit.org/show_bug.cgi?id=134350
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * platform/audio/mac/MediaSessionManagerMac.cpp:
> +	   (MediaSessionManager::updateSessionState): Never call
setActive:false.

nit: Why not?

(Maybe: "Embedding WebView apps may want to enable the audio session outside of
the WebView, and since the AudioSession is global to the app, disabling the
audio session can interrupt that audio."