[webkit-reviews] review granted: [Bug 133546] [JavaScriptCore] FTL buildfix for EFL platform : [Attachment 233163] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 26 09:41:31 PDT 2014

Darin Adler <darin at apple.com> has granted László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 133546: [JavaScriptCore] FTL buildfix for EFL platform

Attachment 233163: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233163&action=review

> Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:67
> +	   if ((static_cast<unsigned>(1) << i) == m_elementSize) {

It’s much better to write this as 1U rather than static_cast<unsigned>(1).

> Source/JavaScriptCore/ftl/FTLStackMaps.cpp:53
> +    out.printf("0x%016llx", static_cast<long long unsigned>(integer));

We normally call the type "unsigned long long" rather than "long long

More information about the webkit-reviews mailing list