[webkit-reviews] review denied: [Bug 99677] When using SVG as an image, we should allow datauri images : [Attachment 233895] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 26 02:24:53 PDT 2014

Dirk Schulze <krit at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 99677: When using SVG as an image, we should allow datauri images

Attachment 233895: Patch

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233895&action=review

r- to make sure that this does not just get landed as is.

> Source/WebCore/ChangeLog:7
> +	   in a SVG images was not loaded in most cases.

On purpose!

> Source/WebCore/ChangeLog:11
> +	   This patch enables auto-loading of images. This only affects data
> +	   URLs since the dummy chrome and page of SVG images still do not
> +	   have a NetworkingContext.

Again, on purpose! No network requests at all from content of SVG images...
dataURLs should be interpreted but the same restrictions apply here as well of

> Source/WebCore/svg/graphics/SVGImage.cpp:367
> +	   m_page->settings()->setLoadsImagesAutomatically(true);

Hm, in theory this allows loading further resources. Is that blocked at a
different place? Could you point out where? Please also add a comment that we
need to be very careful that this does not do any network requests.

> LayoutTests/svg/in-html/resources/embedded.svg:3
> +    <image x="20" y="20" width="30px" height="30px"

Please add examples with an SVG that loads another image decoded with dataURL.

More information about the webkit-reviews mailing list