[webkit-reviews] review granted: [Bug 134337] HIDGamepad should use CFIndex when looping : [Attachment 233884] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 25 22:47:54 PDT 2014


mitz at webkit.org <mitz at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 134337: HIDGamepad should use CFIndex when looping
https://bugs.webkit.org/show_bug.cgi?id=134337

Attachment 233884: Patch
https://bugs.webkit.org/attachment.cgi?id=233884&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233884&action=review


> Source/WebCore/platform/mac/HIDGamepad.cpp:79
> +    CFIndex count = CFArrayGetCount(elements);
> +    for (CFIndex i = 0; i < count; ++i) {

Our usual style for this is for (CFIndex i = 0, count =
CFArrayGetCount(elements); i < count; ++i)


More information about the webkit-reviews mailing list