[webkit-reviews] review granted: [Bug 134284] REGRESSION (r170325): UI process crashes in lastCommittedLayerTreeTransactionID() when the Web Content process crashes : [Attachment 233779] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 25 21:09:05 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 134284: REGRESSION (r170325): UI process crashes in
lastCommittedLayerTreeTransactionID() when the Web Content process crashes
https://bugs.webkit.org/show_bug.cgi?id=134284

Attachment 233779: Patch
https://bugs.webkit.org/attachment.cgi?id=233779&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233779&action=review


> Source/WebKit2/UIProcess/WebPageProxy.h:385
> +    void updateVisibleContentRects(const WebCore::FloatRect& exposedRect,
const WebCore::FloatRect& unobscuredRect, const WebCore::FloatRect&
unobscuredRectInScrollViewCoordinates, const WebCore::FloatRect&
customFixedPositionRect, double scale, bool inStableState, bool
isChangingObscuredInsetsInteractively, double timestamp, double
horizontalVelocity, double verticalVelocity, double scaleChangeRate);

So many arguments.


More information about the webkit-reviews mailing list