[webkit-reviews] review granted: [Bug 134327] [iOS][WK2] Protect WKWebView's delayUpdateVisibleContentRects in case of reentry : [Attachment 233870] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 134327: [iOS][WK2] Protect WKWebView's delayUpdateVisibleContentRects in
case of reentry
https://bugs.webkit.org/show_bug.cgi?id=134327

Attachment 233870: Patch
https://bugs.webkit.org/attachment.cgi?id=233870&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233870&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:188
> +    unsigned _delayUpdateVisibleContentRectsCounter;

int please to make underflow less devastating?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:636
> +    --_delayUpdateVisibleContentRectsCounter;

Please assert that it's > 0

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:-731
> -    _delayUpdateVisibleContentRects = NO;

Set to 0 here?