[webkit-reviews] review granted: [Bug 134324] Add HID-based gamepad implementation for Mac : [Attachment 233867] Patch v1

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 134324: Add HID-based gamepad implementation for Mac
https://bugs.webkit.org/show_bug.cgi?id=134324

Attachment 233867: Patch v1
https://bugs.webkit.org/attachment.cgi?id=233867&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233867&action=review


> Source/WebCore/Modules/gamepad/Gamepad.cpp:45
> +    for (unsigned i = 0; i < platformGamepad.buttonValues().size(); ++i)
> +	   m_buttons.append(GamepadButton::create());

Can this be a C++11 for loop?

> Source/WebCore/Modules/gamepad/GamepadManager.cpp:71
> +    // connectect/disconnected event listeners.

Nit: typo connected

> Source/WebCore/Modules/gamepad/GamepadManager.cpp:83
> +    // connectect/disconnected event listeners.

Ditto