[webkit-reviews] review granted: [Bug 134325] Add new platform gamepad abstractions : [Attachment 233864] Patch v1

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 134325: Add new platform gamepad abstractions
https://bugs.webkit.org/show_bug.cgi?id=134325

Attachment 233864: Patch v1
https://bugs.webkit.org/attachment.cgi?id=233864&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233864&action=review


> Source/WebCore/WebCore.xcodeproj/project.pbxproj:7212
> -		07AC46FF1952102100EE9723 /* ISOVTTCue.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = ISOVTTCue.cpp; path = ISOVTTCue.cpp; sourceTree = "<group>"; };
> -		07AC47001952102100EE9723 /* ISOVTTCue.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
ISOVTTCue.h; path = ISOVTTCue.h; sourceTree = "<group>"; };
> +		07AC46FF1952102100EE9723 /* ISOVTTCue.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
path = ISOVTTCue.cpp; sourceTree = "<group>"; };
> +		07AC47001952102100EE9723 /* ISOVTTCue.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
ISOVTTCue.h; sourceTree = "<group>"; };

Is this intentional?

> Source/WebCore/platform/GamepadStrategy.h:50
> +#endif // ENABLE(GAMEPAD)

Nit: I think we agreed to not bother with these style comments

> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:594
> +#endif // PLATFORM(IOS)
>  
> -#endif
> +#endif // PLATFORM(COCOA)

But here you're adding them, so maybe my memory is incorrect and they should be
around :)