[webkit-reviews] review granted: [Bug 134317] compositing/visible-rect/iframe-no-layers.html is broken and confusing : [Attachment 233855] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 25 17:58:31 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 134317: compositing/visible-rect/iframe-no-layers.html is broken and
confusing
https://bugs.webkit.org/show_bug.cgi?id=134317

Attachment 233855: Patch
https://bugs.webkit.org/attachment.cgi?id=233855&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233855&action=review


> LayoutTests/compositing/visible-rect/iframe-no-layers.html:25
> +	   function testIsDone()

testIsDone is confusing because it's not done until called twice. Add a comment
here saying that one call is from the subframe.


More information about the webkit-reviews mailing list