[webkit-reviews] review granted: [Bug 134316] Crash in ScrollingTree::isRubberBandInProgress() : [Attachment 233853] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 25 17:20:16 PDT 2014

Geoffrey Garen <ggaren at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 134316: Crash in ScrollingTree::isRubberBandInProgress()

Attachment 233853: Patch

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233853&action=review

Am I allowed to review this? Maybe I am.

> Source/WebCore/ChangeLog:13
> +	   believe that the ScrollingCoordinator’s ScrollingTree pointer had
been null-ed out 

Squiggly apostrophe.

> Source/WebCore/ChangeLog:16
> +	   creation back to the scrolling thread and to use the this pointer to
create new 

For clarity, I think "scrolling thread" should be "scrolling tree" here. Node
creation was always happening on the scrolling thread -- but it was using data
from the scrolling coordinator, which was not thread-safe.

> Source/WebCore/ChangeLog:17
> +	   nodes rather than the ScrollingCoordinator’s pointer.


More information about the webkit-reviews mailing list