[webkit-reviews] review granted: [Bug 133609] CSS JIT: Reflect parent fragment's relations to sub fragments : [Attachment 233740] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 133609: CSS JIT: Reflect parent fragment's relations to sub fragments
https://bugs.webkit.org/show_bug.cgi?id=133609

Attachment 233740: Patch
https://bugs.webkit.org/attachment.cgi?id=233740&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233740&action=review


> Source/WebCore/cssjit/SelectorCompiler.cpp:345
> +static inline bool isRightmostInRootFragments(const SelectorFragment&
fragment)
> +{
> +    return fragment.relationToRightFragment == FragmentRelation::Rightmost
&& fragment.positionInRootFragments ==
FragmentPositionInRootFragments::Rightmost;
> +}

I would rename this by how it is used for code generation.
Maybe: shouldUseRenderStyleFromCheckingContext()?