[webkit-reviews] review granted: [Bug 134267] iOS WebKit2: block selection tends to prefer block to single words even when the page is zoomed. : [Attachment 233734] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 24 13:32:50 PDT 2014


Benjamin Poulain <benjamin at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 134267: iOS WebKit2: block selection tends to prefer block to single words
even when the page is zoomed.
https://bugs.webkit.org/show_bug.cgi?id=134267

Attachment 233734: Patch
https://bugs.webkit.org/attachment.cgi?id=233734&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
The change makes sense. I would create a second rect (a FloatRect) especially
for that purpose. Something like:
    FloatRect boundingRectInScrollViewCoordinates(boundingRect);
    boundingRectInScrollViewCoordinates.scale(...).

To make it explicit which that rect is not in document coordinates.


More information about the webkit-reviews mailing list