[webkit-reviews] review granted: [Bug 134173] InlineTextBox's m_len can be an unsigned (rather than an unsigned short) : [Attachment 233670] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 134173: InlineTextBox's m_len can be an unsigned (rather than an unsigned
short)
https://bugs.webkit.org/show_bug.cgi?id=134173

Attachment 233670: Patch
https://bugs.webkit.org/attachment.cgi?id=233670&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233670&action=review


OK

> Source/WebCore/rendering/InlineTextBox.h:38
> +const unsigned cNoTruncation = UINT_MAX;
> +const unsigned cFullTruncation = UINT_MAX - 1;

We should take this opportunity to substitute the C++ idiom of
std::numeric_limits<unsigned>::max() for UINT_MAX in these lines.