[webkit-reviews] review granted: [Bug 134122] [iOS] getsectdata() is deprecated and we use it in DRT : [Attachment 233567] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 134122: [iOS] getsectdata() is deprecated and we use it in DRT
https://bugs.webkit.org/show_bug.cgi?id=134122

Attachment 233567: Patch
https://bugs.webkit.org/attachment.cgi?id=233567&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233567&action=review


Nice!

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:517
> +static void activateFontIOS(const uint8_t* ptr, unsigned long length,
std::string sectionName)

I suggest using a more descriptive name for "ptr" (maybe fontData?)

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:519
> +    CGDataProviderRef data = CGDataProviderCreateWithData(NULL, ptr, length,
NULL);

s/NULL/nullptr/g

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:538
> +}
> +static void activateFontsIOS()

Missing empty line.