[webkit-reviews] review denied: [Bug 133782] [WK2][EFL] Implement text selection range and url's copy and paste through EFL MiniBrowser Context Menu : [Attachment 233351] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at webkit.org> has denied Joonghun Park
<jh718.park at samsung.com>'s request for review:
Bug 133782: [WK2][EFL] Implement text selection range and url's copy and paste
through EFL MiniBrowser Context Menu
https://bugs.webkit.org/show_bug.cgi?id=133782

Attachment 233351: Patch
https://bugs.webkit.org/attachment.cgi?id=233351&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233351&action=review


This patch is almost copied from GTK implementation. So, please consider my
suggestion. So, r-

> Source/WebCore/ChangeLog:4
> +	   Need the bug URL (OOPS!).

Remove this template.

> Source/WebCore/ChangeLog:7
> +

Missing patch description.

> Source/WebCore/platform/efl/DataObjectEfl.cpp:4
> +    This library is free software; you can redistribute it and/or

Use BSD instead of LGPL license.

> Source/WebCore/platform/efl/DataObjectEfl.h:20
> +#ifndef DataObjectEfl_h

It looks DataObjectGtk.h/cpp files are almost same with DataObjectGtk.h/cpp. In
this case, you have to add *original author* in Licence. Besides I think we can
share common functions with GTK port. So, we may make DataObject.h/cpp to be
shared by GTK and EFL. Then, we make DataObjectGtk.h/cpp and
DataObjectEfl.h/cpp to support port specific implementation.