[webkit-reviews] review granted: [Bug 134216] Initialize WKWebViewConfiguration properties to their default values. : [Attachment 233639] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 23 15:43:15 PDT 2014
Anders Carlsson <andersca at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 134216: Initialize WKWebViewConfiguration properties to their default
values.
https://bugs.webkit.org/show_bug.cgi?id=134216
Attachment 233639: Patch
https://bugs.webkit.org/attachment.cgi?id=233639&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233639&action=review
> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:82
> +- (instancetype)init {
Newline before {
> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:87
> + _allowsInlineMediaPlayback = NO;
No need to initialize this, it'll be NO by default.
> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:91
> + return self;
I'd add an extra newline here.
More information about the webkit-reviews
mailing list