[webkit-reviews] review granted: [Bug 134189] [wk2] Synchronously wait a short time for a layer tree update after bringing a web view in-window : [Attachment 233589] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 134189: [wk2] Synchronously wait a short time for a layer tree update after
bringing a web view in-window
https://bugs.webkit.org/show_bug.cgi?id=134189

Attachment 233589: patch
https://bugs.webkit.org/attachment.cgi?id=233589&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233589&action=review


> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:327
> +    auto viewStateUpdateTimeout = std::chrono::milliseconds(500);

500 vs...

> Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:132
> +    auto viewStateUpdateTimeout = std::chrono::milliseconds(250);

250?

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:124
> +	   static PassRefPtr<BackingStoreFlusher> create(FlushingContext);

Did you mean to pass by value?

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:320
> +    BackingStoreFlusher::FlushingContext flushingContext;

I can has constructor?