[webkit-reviews] review requested: [Bug 134208] Reduce synchronous layout triggered by JavaScript-based media controls : [Attachment 233628] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 134208: Reduce synchronous layout triggered by JavaScript-based media
controls
https://bugs.webkit.org/show_bug.cgi?id=134208

Attachment 233628: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=233628&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Based on measurements from Andreas this improved PLT by ~0.5%. It reduces the
number of calls to offsetWidth from 8 to 3 when just loading a page with a
video and controls.

I see one possible issue with this patch, if the media element itself changes
size the cached values may be wrong. That is because the timeline is flex based
and we do not know when the element itself changed size. So that may be a
regression that could be addressed later.